feat: Add AsyncApprovalNotificationChannels support to Client #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add AsyncApprovalNotificationChannels field to Client struct in management/client.go - Auto-generate GetAsyncApprovalNotificationChannels getter method in management.gen.go - Auto-generate test for GetAsyncApprovalNotificationChannels in management.gen_test.go This feature allows configuring notification channels for contacting users when their approval is required. Valid values: "guardian-push", "email". Default value: ["guardian-push"]
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v1 #635 +/- ##
=======================================
Coverage 96.29% 96.29%
=======================================
Files 62 62
Lines 12975 12980 +5
=======================================
+ Hits 12494 12499 +5
Misses 363 363
Partials 118 118 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Changes seems fine, Please add some unit tests! |
kushalshit27
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
This feature allows configuring notification channels for contacting users when their approval is required.
The field is optional and can be null. To unset values, use a PATCH request with null value.
📚 References
🔬 Testing
📝 Checklist